check links #49
Draft
check links #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
learn — restyled left sidebar
Co-authored-by: Martin Bonnin <[email protected]>
Co-authored-by: Martin Bonnin <[email protected]>
Co-authored-by: Martin Bonnin <[email protected]>
Co-authored-by: Martin Bonnin <[email protected]>
* Render MiniGraphiQL with `graphiql` string in node.meta * Don't validate in Marked: not its responsibility * Change interactive code snippet colors * Remove global .miniGraphiQL class * Refactor MiniGraphiQL to separate files * Add a TODO comment * Run Playwright on CI * wip * color codemirrors properly * Style codemirrors properly * Upgrade pnpm from 9.15.9 to 10.15.0 * Update 2025 conference schedule and speaker details * Improve syntax highlighting for comments and diffs * Remove focus outline * Extract CodeBlockLabel * Remove unused marked dependency * Rename `marked` to `interactive-code-block` * Update codemirror styles * Allow running esbuild builds * Remove duplicate image * Format * Change syntax theme names to avoid a bug * Fix heights and properly chain handlers * Fix tests for new editor * Run Playwright on CI * Use the same colors for VariableEditor * Use the same font for interactive code blocks * Match the coloring on t.separator [,:] between Lezer and Shiki
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hasparus
force-pushed
the
check-links
branch
from
f35cf2a to
601b39e
Compare
hasparus
force-pushed
the
source
branch
2 times, most recently
from
a7ae87a to
b600a58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the
lycheeCI action never worked and we wanted to validate the links, I wrote a small script to generate raports that can later be inspected with some diff tool like:It's not really ready to run on PRs because the links would have to be flattened and compared, and we'd need to use vercel.json to exit early on redirects (like flickr or graphql-js.org)
It has some false positives that we'd need to filter out:
e.g. Flickr Gallery Links: In the /conf/2024/gallery/ section of the graphql.org report, there is a large number of 404 errors for URLs within flickr.com. They are internal navigational links from the photo gallery, because we redirect from internal path to flickr and the scanner doesn't know vercel.json.